lkml.org 
[lkml]   [2022]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH -next] ARM: davinci: da850-evm: add missing platform_device_unregister in da850_lcd_hw_init
On Wed, May 11, 2022 at 10:51 AM Zheng Bin <zhengbin13@huawei.com> wrote:
>
> da850_lcd_hw_init misses a call platform_device_unregister in error path,
> this patch fixes that.
>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
> ---
> arch/arm/mach-davinci/board-da850-evm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-davinci/board-da850-evm.c b/arch/arm/mach-davinci/board-da850-evm.c
> index efc26b472ef8..7b2a1a37e5c0 100644
> --- a/arch/arm/mach-davinci/board-da850-evm.c
> +++ b/arch/arm/mach-davinci/board-da850-evm.c
> @@ -873,8 +873,10 @@ static int da850_lcd_hw_init(void)
> return PTR_ERR(backlight);
>
> status = platform_device_register(&da850_lcd_supply_device);
> - if (status)
> + if (status) {
> + platform_device_unregister(backlight);
> return status;
> + }
>
> return 0;
> }
> --
> 2.31.1
>

Reviewed-by: Bartosz Golaszewski <brgl@bgdev.pl>

\
 
 \ /
  Last update: 2022-05-14 14:40    [W:0.028 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site