lkml.org 
[lkml]   [2022]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 13/29] iommu/amd: Compose MSI messages for NMI irqs in non-IR format
On Fri, May 06, 2022 at 11:31:56PM +0200, Thomas Gleixner wrote:
> On Thu, May 05 2022 at 16:59, Ricardo Neri wrote:
> > + *
> > + * Also, NMIs do not have an associated vector. No need for cleanup.
>
> They have a vector and what the heck is this cleanup comment for here?
> There is nothing cleanup alike anywhere near.
>
> Adding confusing comments is worse than adding no comments at all.

I will remove the comment regarding cleanup. I will clarify that NMI has a
fixed vector.

Thanks and BR,
Ricardo

\
 
 \ /
  Last update: 2022-05-13 21:01    [W:0.085 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site