lkml.org 
[lkml]   [2022]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 6/7] perf jevents: Switch build to use jevents.py
From
On 11/05/2022 22:15, Ian Rogers wrote:
> # jevents.py uses os.scandir and type hints present in Python 3.5 released in Sept. 2015.
> + JEVENTS_PYTHON_GOOD := $(shell $(PYTHON) -c 'import sys;print("1" if(sys.version_info.major >= 3 and sys.version_info.minor >= 5) else "0")')

I think that many - like me - will have python 2.7, so now will find no
pmu-events generated any longer after missing this message in the build :(

Maybe many will have python >= 3.5 - but I don't know...

> + ifneq ($(JEVENTS_PYTHON_GOOD), 1)
> + $(warning Python interpreter too old (older than 3.5) disabling
jevent generation)
> + NO_JEVENTS := 1

It is possible to flip NO_JEVENTS to be JEVENTS, i.e. no
double-negatives, like NO_JEVENTS := 0

> + endif

Thanks,
John

\
 
 \ /
  Last update: 2022-05-13 17:41    [W:0.118 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site