Messages in this thread | | | Date | Fri, 13 May 2022 22:47:10 +0800 | From | kernel test robot <> | Subject | Re: [PATCH 5/6] mtd: spi-nor: add generic flash driver |
| |
Hi Michael,
I love your patch! Perhaps something to improve:
[auto build test WARNING on mtd/spi-nor/next] [also build test WARNING on next-20220513] [cannot apply to linux/master linus/master v5.18-rc6] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Michael-Walle/mtd-spi-nor-generic-flash-driver/20220513-214238 base: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git spi-nor/next config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20220513/202205132220.uRTFaqNA-lkp@intel.com/config) compiler: m68k-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/d38c0ac1528d85bea65fc5a9e7f61a10dbc051fb git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Michael-Walle/mtd-spi-nor-generic-flash-driver/20220513-214238 git checkout d38c0ac1528d85bea65fc5a9e7f61a10dbc051fb # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/mtd/spi-nor/
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/mtd/spi-nor/sfdp.c:1260: warning: expecting prototype for spi_nor_check_sfdp_header(). Prototype was for spi_nor_check_sfdp_signature() instead
vim +1260 drivers/mtd/spi-nor/sfdp.c
1249 1250 /** 1251 * spi_nor_check_sfdp_header() - check for a valid SFDP header 1252 * @nor: pointer to a 'struct spi_nor' 1253 * 1254 * Used to detect if the flash supports the RDSFDP command as well as the 1255 * presence of a valid SFDP table. 1256 * 1257 * Return: 0 on success, -errno otherwise. 1258 */ 1259 int spi_nor_check_sfdp_signature(struct spi_nor *nor) > 1260 { 1261 u32 signature; 1262 int err; 1263 1264 /* Get the SFDP header. */ 1265 err = spi_nor_read_sfdp_dma_unsafe(nor, 0, sizeof(signature), 1266 &signature); 1267 if (err < 0) 1268 return err; 1269 1270 /* Check the SFDP signature. */ 1271 if (le32_to_cpu(signature) != SFDP_SIGNATURE) 1272 return -EINVAL; 1273 1274 return 0; 1275 } 1276
-- 0-DAY CI Kernel Test Service https://01.org/lkp
| |