lkml.org 
[lkml]   [2022]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 14/15] mm/swap: fix the comment of get_kernel_pages
From
Date
On 2022/5/12 21:45, David Hildenbrand wrote:
> On 09.05.22 15:14, Miaohe Lin wrote:
>> If no pages were pinned, 0 is returned in fact. Fix the corresponding
>> comment.
>>
>> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
>> ---
>> mm/swap.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/mm/swap.c b/mm/swap.c
>> index 6d2c37f781f8..236b37663a1a 100644
>> --- a/mm/swap.c
>> +++ b/mm/swap.c
>> @@ -168,8 +168,8 @@ EXPORT_SYMBOL(put_pages_list);
>> *
>> * Returns number of pages pinned. This may be fewer than the number
>> * requested. If nr_pages is 0 or negative, returns 0. If no pages
>
> Ehm, there is only "nr_segs", no "nr_pages" :/ Want to fix that up in
> the same patch?

Will do.

>
>> - * were pinned, returns -errno. Each page returned must be released
>> - * with a put_page() call when it is finished with.
>> + * were pinned, returns 0. Each page returned must be released with
>> + * a put_page() call when it is finished with.
>> */
>> int get_kernel_pages(const struct kvec *kiov, int nr_segs, int write,
>> struct page **pages)
>
> Apart from that
>
> Reviewed-by: David Hildenbrand <david@redhat.com>

Many thanks for review and comment!

>

\
 
 \ /
  Last update: 2022-05-13 08:17    [W:0.384 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site