Messages in this thread | | | Date | Fri, 13 May 2022 13:56:28 +0200 | From | Marc Kleine-Budde <> | Subject | Re: [PATCH] can: xilinx_can: Add Transmitter delay compensation (TDC) feature support |
| |
On 13.05.2022 10:24:06, Vincent Mailhol wrote: > > #define XCAN_BTR_SJW_SHIFT 7 /* Synchronous jump width */ > > #define XCAN_BTR_TS2_SHIFT 4 /* Time segment 2 */ > > #define XCAN_BTR_SJW_SHIFT_CANFD 16 /* Synchronous jump width */ > > @@ -259,7 +261,7 @@ static const struct can_bittiming_const xcan_bittiming_const_canfd2 = { > > .tseg2_min = 1, > > .tseg2_max = 128, > > .sjw_max = 128, > > - .brp_min = 2, > > + .brp_min = 1, > > Was there any reason to have brp_min = 2 in the first place? > I think this change should be a different patch. If the brp_min = 2 > is just a typo, you might also want to backport it to stable branches.
+1
Marc
-- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | [unhandled content-type:application/pgp-signature] | |