lkml.org 
[lkml]   [2022]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] mtd: st_spi_fsm: add missing clk_disable_unprepare() stfsm_remove()
Hi,

yangyingliang@huawei.com wrote on Fri, 13 May 2022 18:03:22 +0800:

> Clock source is prepared and enabled by clk_prepare_enable()
> in probe function, but no disable or unprepare in remove function.

not disabled or unprepared

Otherwise looks good.

>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/mtd/devices/st_spi_fsm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/devices/st_spi_fsm.c b/drivers/mtd/devices/st_spi_fsm.c
> index 983999c020d6..d3377b10fc0f 100644
> --- a/drivers/mtd/devices/st_spi_fsm.c
> +++ b/drivers/mtd/devices/st_spi_fsm.c
> @@ -2126,6 +2126,8 @@ static int stfsm_remove(struct platform_device *pdev)
> {
> struct stfsm *fsm = platform_get_drvdata(pdev);
>
> + clk_disable_unprepare(fsm->clk);
> +
> return mtd_device_unregister(&fsm->mtd);
> }
>


Thanks,
Miquèl

\
 
 \ /
  Last update: 2022-05-13 12:23    [W:0.686 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site