Messages in this thread | | | Date | Fri, 13 May 2022 10:24:04 +0200 | Subject | Re: [PATCH 5/7] arm64: dts: qcom: Add PM6125 PMIC | From | Krzysztof Kozlowski <> |
| |
On 12/05/2022 00:06, Marijn Suijten wrote: > This PMIC is commonly used on boards with an SM6125 SoC and looks very > similar in layout to the PM6150. > > Downstream declares more nodes to be available, but these have been > omitted from this patch: the pwm/lpg block is unused on my reference > device making it impossible to test/validate, and the spmi-clkdiv does > not have a single device-tree binding using this driver yet, hence > inclusion is better postponed until ie. audio which uses these clocks is > brought up. > > Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> > Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Two reviews on first patch... :)
> + > + pmic@1 { > + compatible = "qcom,pm6125", "qcom,spmi-pmic"; > + reg = <0x1 SPMI_USID>; > + #address-cells = <1>; > + #size-cells = <0>;
No children, so this should not be needed, I think.
> + }; > +};
Best regards, Krzysztof
| |