Messages in this thread | | | Date | Fri, 13 May 2022 10:10:43 +0200 | Subject | Re: [PATCH v15 10/10] ARM: dts: Add Sunplus SP7021-Demo-V3 board device tree | From | Krzysztof Kozlowski <> |
| |
On 13/05/2022 09:44, qinjian[覃健] wrote: >>> diff --git a/arch/arm/boot/dts/sunplus-sp7021-achip.dtsi b/arch/arm/boot/dts/sunplus-sp7021-achip.dtsi >>> new file mode 100644 >>> index 000000000..1560c95d9 >>> --- /dev/null >>> +++ b/arch/arm/boot/dts/sunplus-sp7021-achip.dtsi >>> @@ -0,0 +1,85 @@ >>> +// SPDX-License-Identifier: GPL-2.0 >>> +/* >>> + * Device Tree Source for Sunplus SP7021 >>> + * >>> + * Copyright (C) 2021 Sunplus Technology Co. >>> + */ >>> + >>> +#include "sunplus-sp7021.dtsi" >>> + >>> +/ { >>> + compatible = "sunplus,sp7021-achip"; >> >> This does not match your bindings. >> > >>> +++ b/arch/arm/boot/dts/sunplus-sp7021-demo-v3.dts >>> @@ -0,0 +1,27 @@ >>> +// SPDX-License-Identifier: GPL-2.0 >>> +/* >>> + * Device Tree Source for Sunplus SP7021 Demo V3 SBC board >>> + * >>> + * Copyright (C) Sunplus Technology Co. >>> + */ >>> + >>> +/dts-v1/; >>> + >>> +#include "sunplus-sp7021-achip.dtsi" >>> + >>> +/ { >>> + compatible = "sunplus,sp7021-demo-v3"; >> >> This does not match your bindings. >> >> Please run make dtbs_check. > > I did passed the make dtbs_check. > compatible string: "sunplus,sp7021", "sunplus,sp7021-achip", "sunplus,sp7021-demo-v3" > all defined @ Documentation/devicetree/bindings/arm/sunplus,sp7021.yaml [1]
How this can pass the check if it is entirely different compatible and does not match schema? The code is not correct. If you test your DTS with dtbs_check you will see:
sunplus-sp7021-demo-v3.dtb: /: compatible: ['sunplus,sp7021-demo-v3'] is too short
Additionally: 1. Your DTBs do not compile, missing Makefile entry.
2. You have to fix whitespace issues in your patches:
.git/rebase-apply/patch:48: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
.git/rebase-apply/patch:97: new blank line at EOF.
+
warning: 1
Best regards, Krzysztof
| |