lkml.org 
[lkml]   [2022]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] tty/termbits: remove #ifdef IBSHIFT that is always defined
On Wed, May 11, 2022 at 01:11:37PM +0300, Ilpo Järvinen wrote:
> IBSHIFT is defined by all architectures.

This also changed recently so mention the commit in question.

Subject is overly verbose here too.

> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
> drivers/tty/tty_baudrate.c | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/drivers/tty/tty_baudrate.c b/drivers/tty/tty_baudrate.c
> index 07bbbfee5635..d10318956c97 100644
> --- a/drivers/tty/tty_baudrate.c
> +++ b/drivers/tty/tty_baudrate.c

> @@ -194,12 +187,10 @@ void tty_termios_encode_baud_rate(struct ktermios *termios,
> */
> if (ofound == i && !ibinput)
> ifound = i;
> -#ifdef IBSHIFT
> else {
> ifound = i;
> termios->c_cflag |= (baud_bits[i] << IBSHIFT);
> }
> -#endif

Please add the missing brackets to the if branch when removing the ifdef.

Johan

\
 
 \ /
  Last update: 2022-05-13 09:12    [W:0.062 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site