lkml.org 
[lkml]   [2022]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 10/20] media: rkvdec: h264: Fix bit depth wrap in pps packet
    Date
    From: Jonas Karlman <jonas@kwiboo.se>

    The luma and chroma bit depth fields in the pps packet are 3 bits wide.
    8 is wrongly added to the bit depth values written to these 3 bit fields.
    Because only the 3 LSB are written, the hardware was configured
    correctly.

    Correct this by not adding 8 to the luma and chroma bit depth value.

    Fixes: cd33c830448ba ("media: rkvdec: Add the rkvdec driver")
    Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
    Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
    Reviewed-by: Ezequiel Garcia <ezequiel@collabora.com>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    ---
    drivers/staging/media/rkvdec/rkvdec-h264.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/staging/media/rkvdec/rkvdec-h264.c b/drivers/staging/media/rkvdec/rkvdec-h264.c
    index bcde37d72244..8d44a884a52e 100644
    --- a/drivers/staging/media/rkvdec/rkvdec-h264.c
    +++ b/drivers/staging/media/rkvdec/rkvdec-h264.c
    @@ -662,8 +662,8 @@ static void assemble_hw_pps(struct rkvdec_ctx *ctx,
    WRITE_PPS(0xff, PROFILE_IDC);
    WRITE_PPS(1, CONSTRAINT_SET3_FLAG);
    WRITE_PPS(sps->chroma_format_idc, CHROMA_FORMAT_IDC);
    - WRITE_PPS(sps->bit_depth_luma_minus8 + 8, BIT_DEPTH_LUMA);
    - WRITE_PPS(sps->bit_depth_chroma_minus8 + 8, BIT_DEPTH_CHROMA);
    + WRITE_PPS(sps->bit_depth_luma_minus8, BIT_DEPTH_LUMA);
    + WRITE_PPS(sps->bit_depth_chroma_minus8, BIT_DEPTH_CHROMA);
    WRITE_PPS(0, QPPRIME_Y_ZERO_TRANSFORM_BYPASS_FLAG);
    WRITE_PPS(sps->log2_max_frame_num_minus4, LOG2_MAX_FRAME_NUM_MINUS4);
    WRITE_PPS(sps->max_num_ref_frames, MAX_NUM_REF_FRAMES);
    --
    2.34.3
    \
     
     \ /
      Last update: 2022-05-13 22:32    [W:3.479 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site