Messages in this thread | | | Date | Thu, 12 May 2022 18:09:09 +0200 | From | Thomas Bogendoerfer <> | Subject | Re: [PATCH] MIPS: tools: no need to initialise statics to 0 |
| |
On Sun, May 08, 2022 at 10:31:46AM +0800, Jason Wang wrote: > Static variables do not need to be initialised to 0, because compiler > will initialise all uninitialised statics to 0. Thus, remove the > unneeded initializations. > > Signed-off-by: Jason Wang <wangborong@cdjrlc.com> > --- > arch/mips/boot/tools/relocs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/boot/tools/relocs.c b/arch/mips/boot/tools/relocs.c > index 1bf53f3524b3..02fc85f3e8ff 100644 > --- a/arch/mips/boot/tools/relocs.c > +++ b/arch/mips/boot/tools/relocs.c > @@ -351,7 +351,7 @@ static void read_symtabs(FILE *fp) > > static void read_relocs(FILE *fp) > { > - static unsigned long base = 0; > + static unsigned long base; > int i, j; > > if (!base) { > -- > 2.35.1
applied to mips-next.
Thomas.
-- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
| |