lkml.org 
[lkml]   [2022]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] usb: hub: Simplify error and success path in port_over_current_notify
Dear Greg,

On Do, Mai 12, 2022 at 01:38:36 +0200, Greg Kroah-Hartman wrote:
> On Thu, May 12, 2022 at 01:15:27PM +0200, Eugeniu Rosca wrote:
> > From: Bhuvanesh Surachari <Bhuvanesh_Surachari@mentor.com>

[..]

> > if (!envp[1])
> > - goto exit;
> > + goto exit_path;
>
> No need to rename this, right?
>
> >
> > - envp[2] = NULL;
> > kobject_uevent_env(&hub_dev->kobj, KOBJ_CHANGE, envp);
> >
> > +exit_path:
> > kfree(envp[1]);
> > -exit:
>
> Move this up one line?

Thank you for your comments. Much appreciated.

Please, find the updated version at:
https://lore.kernel.org/linux-usb/1652369834-4480-1-git-send-email-erosca@de.adit-jv.com

Best regards,
Eugeniu

\
 
 \ /
  Last update: 2022-05-12 17:45    [W:0.088 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site