Messages in this thread | | | Date | Thu, 12 May 2022 17:33:04 +0200 | Subject | Re: [PATCH] drm/meson: Fix refcount leak in meson_encoder_hdmi_init | From | Neil Armstrong <> |
| |
Hi,
On 12/05/2022 14:38, Martin Blumenstingl wrote: > On Wed, May 11, 2022 at 7:41 AM Miaoqian Lin <linmq006@gmail.com> wrote: >> >> of_find_device_by_node() takes reference, we should use put_device() >> to release it when not need anymore. >> Add missing put_device() in error path to avoid refcount >> leak. >> >> Fixes: 0af5e0b41110 ("drm/meson: encoder_hdmi: switch to bridge DRM_BRIDGE_ATTACH_NO_CONNECTOR") >> Signed-off-by: Miaoqian Lin <linmq006@gmail.com> > Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > Thanks for sending this patch! > > Neil, while reviewing this I noticed that on module unload we're also > not calling put_device(). > This note doesn't affect this patch - but I am wondering if we need to > put that put_device() during module unload on our TODO-list? >
Indeed, it should be fixed.
Neil
> > Best regards, > Martin
| |