lkml.org 
[lkml]   [2022]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v6 7/7] arm64: dts: mt8195: Add thermal zone
    From
    On 12/05/2022 14:24, Alexandre Bailon wrote:
    > From: Tinghan Shen <tinghan.shen@mediatek.com>
    >
    > This adds the thermal zone for the mt8195.
    >
    > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
    > Signed-off-by: Ben Tseng <ben.tseng@mediatek.com>
    > Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
    > ---
    > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 103 +++++++++++++++++++++++
    > 1 file changed, 103 insertions(+)
    >
    > diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
    > index 12887fb4d0d1..d6e5b595a89f 100644
    > --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
    > +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
    > @@ -823,6 +823,21 @@ spi0: spi@1100a000 {
    > status = "disabled";
    > };
    >
    > + lvts: lvts@1100b000 {

    Generic node names.

    > + compatible = "mediatek,mt8195-lvts";
    > + #thermal-sensor-cells = <1>;
    > + reg = <0 0x1100b000 0 0x1000>,
    > + <0 0x11278000 0 0x1000>;
    > + interrupts = <GIC_SPI 169 IRQ_TYPE_LEVEL_HIGH 0>,
    > + <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH 0>;
    > + clocks = <&infracfg_ao CLK_INFRA_AO_THERM>;
    > + clock-names = "lvts_clk";
    > + resets = <&infracfg_rst 1>,
    > + <&infracfg_rst 2>;
    > + nvmem-cells = <&lvts_e_data1 &lvts_e_data2>;
    > + nvmem-cell-names = "e_data1","e_data2";
    > + };
    > +
    > spi1: spi@11010000 {
    > compatible = "mediatek,mt8195-spi",
    > "mediatek,mt6765-spi";
    > @@ -1627,4 +1642,92 @@ vencsys_core1: clock-controller@1b000000 {
    > #clock-cells = <1>;
    > };
    > };
    > +
    > + thermal_zones: thermal-zones {
    > + cpu_big1 {

    No underscores in node names. Generic node names - please open existing
    thermal zones schema and look how it is done. This probably fails
    validation, so be sure your DTS passes make dtbs_check.

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2022-05-12 16:33    [W:3.954 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site