lkml.org 
[lkml]   [2022]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] kunit: tool: stop using a shell to run kernel under QEMU
On Wed, May 11, 2022 at 4:22 PM Brendan Higgins
<brendanhiggins@google.com> wrote:
> > + extra_qemu_params=[])
> > diff --git a/tools/testing/kunit/qemu_configs/powerpc.py b/tools/testing/kunit/qemu_configs/powerpc.py
> > index 35e9de24f0db..6c901149726b 100644
> > --- a/tools/testing/kunit/qemu_configs/powerpc.py
> > +++ b/tools/testing/kunit/qemu_configs/powerpc.py
> > @@ -9,4 +9,4 @@ CONFIG_HVC_CONSOLE=y''',
> > qemu_arch='ppc64',
> > kernel_path='vmlinux',
> > kernel_command_line='console=ttyS0',
> > - extra_qemu_params=['-M pseries', '-cpu power8'])
> > + extra_qemu_params=['-M', ' pseries', '-cpu', 'power8'])
>
> This should be '-M', 'pseries', not '-M', ' pseries', (you left an
> extra space in.
>
> Note this actually breaks QEMU on my machine.

Thanks for catching this!

Ugh, I must have sent out a stale version of the .patch file.
My tree has the fix since I noticed it right as I was preparing to
send this out.

I have this locally:
- extra_qemu_params=['-M pseries', '-cpu power8'])
+ extra_qemu_params=['-M', 'pseries', '-cpu',
'power8'])

Sent out as v2,
https://lore.kernel.org/linux-kselftest/20220512142555.3554396-1-dlatypov@google.com

\
 
 \ /
  Last update: 2022-05-12 16:29    [W:0.061 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site