Messages in this thread | | | Date | Thu, 12 May 2022 16:11:48 +0200 | Subject | Re: [PATCH V4 0/5] Add initial support for MA35D1 SoC | From | Krzysztof Kozlowski <> |
| |
On 10/05/2022 09:07, Arnd Bergmann wrote: > On Tue, May 10, 2022 at 5:25 AM Jacky Huang <ychuang3@nuvoton.com> wrote: >> >> This patch series adds initial support for Nuvoton MA35D1 SoC, >> include initial dts and clock controller binding. >> > > This looks fine in principle, but we are getting close to the merge window and > should finalize this quickly to make it into v5.19. I see that you don't have a > console device, as commented in the .dts patch. Normally I prefer merging > platforms only when there is at least rudimentary support for booting into > an initramfs with a serial console, but this is a flexible rule.
I disagree. It does not look fine - does not pass `make dtbs_check` even with Nuvoton bindings...
Best regards, Krzysztof
| |