Messages in this thread | | | Date | Thu, 12 May 2022 08:13:59 -0500 | Subject | Re: [PATCH -next] ASoC: SOF: amd: add missing platform_device_unregister in acp_pci_rn_probe | From | Pierre-Louis Bossart <> |
| |
On 5/11/22 20:37, Zheng Bin wrote: > acp_pci_rn_probe misses a call platform_device_unregister in error path, > this patch fixes that. > > Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
Thanks for the patch, nice catch
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> --- > sound/soc/sof/amd/pci-rn.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/soc/sof/amd/pci-rn.c b/sound/soc/sof/amd/pci-rn.c > index b8910bb7f27c..d5d9bcc2c997 100644 > --- a/sound/soc/sof/amd/pci-rn.c > +++ b/sound/soc/sof/amd/pci-rn.c > @@ -101,6 +101,7 @@ static int acp_pci_rn_probe(struct pci_dev *pci, const struct pci_device_id *pci > res = devm_kzalloc(&pci->dev, sizeof(struct resource) * ARRAY_SIZE(renoir_res), GFP_KERNEL); > if (!res) { > sof_pci_remove(pci); > + platform_device_unregister(dmic_dev); > return -ENOMEM; > } > > -- > 2.31.1 >
| |