lkml.org 
[lkml]   [2022]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] gpio: ml-ioh: Add devm_free_irq() call to remove flow
Date
When removing the module, we will get the following flaw:

[ 14.204955] remove_proc_entry: removing non-empty directory 'irq/21', leaking at least 'gpio_ml_ioh'
[ 14.205827] WARNING: CPU: 0 PID: 305 at fs/proc/generic.c:717 remove_proc_entry+0x389/0x3f0
[ 14.209994] RIP: 0010:remove_proc_entry+0x389/0x3f0
[ 14.217820] Call Trace:
[ 14.218057] <TASK>
[ 14.218264] unregister_irq_proc+0x14c/0x170
[ 14.218674] irq_free_descs+0x94/0xe0
[ 14.219019] mp_unmap_irq+0xb6/0x100
[ 14.219357] acpi_unregister_gsi_ioapic+0x27/0x40
[ 14.219796] acpi_pci_irq_disable+0x1d3/0x320
[ 14.220206] pci_disable_device+0x1ad/0x380
[ 14.220613] ioh_gpio_remove+0xc5/0xe0 [gpio_ml_ioh]
[ 14.221075] pci_device_remove+0x92/0x240

Fix this bug by adding devm_free_irq() call to remove flow.

Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
---
drivers/gpio/gpio-ml-ioh.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/gpio/gpio-ml-ioh.c b/drivers/gpio/gpio-ml-ioh.c
index b060c4773698..09bf317876b0 100644
--- a/drivers/gpio/gpio-ml-ioh.c
+++ b/drivers/gpio/gpio-ml-ioh.c
@@ -508,6 +508,8 @@ static void ioh_gpio_remove(struct pci_dev *pdev)
struct ioh_gpio *chip = pci_get_drvdata(pdev);
void *chip_save;

+ devm_free_irq(&pdev->dev, pdev->irq, chip);
+
chip_save = chip;

for (i = 0; i < 8; i++, chip++)
--
2.25.1
\
 
 \ /
  Last update: 2022-05-12 13:23    [W:0.034 / U:3.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site