| Date | Thu, 12 May 2022 09:00:43 +0200 | Subject | Re: [PATCH v3 15/23] ata: libahci: Don't read AHCI version twice in the save-config method | From | Hannes Reinecke <> |
| |
On 5/12/22 01:18, Serge Semin wrote: > There is no point in reading the AHCI version all over in the tail of the > ahci_save_initial_config() method. That register is RO and doesn't change > its value even after reset. So just reuse the data, which has already been > read from there earlier in the head of the function. > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > --- > drivers/ata/libahci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c > index 000a7072614f..1ffaa5f5f21a 100644 > --- a/drivers/ata/libahci.c > +++ b/drivers/ata/libahci.c > @@ -564,7 +564,7 @@ void ahci_save_initial_config(struct device *dev, struct ahci_host_priv *hpriv) > /* record values to use during operation */ > hpriv->cap = cap; > hpriv->cap2 = cap2; > - hpriv->version = readl(mmio + HOST_VERSION); > + hpriv->version = vers; > hpriv->port_map = port_map; > > if (!hpriv->start_engine)
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
|