lkml.org 
[lkml]   [2022]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V5 3/5] iio: accel: sca3300: modified to support multi chips
Hi LI,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on jic23-iio/togreg]
[also build test WARNING on v5.18-rc6 next-20220512]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/intel-lab-lkp/linux/commits/LI-Qingwu/iio-accel-sca3300-add-compatible-for-scl3300/20220513-000857
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: hexagon-randconfig-r041-20220512 (https://download.01.org/0day-ci/archive/20220513/202205130824.ObRAkagG-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 9519dacab7b8afd537811fc2abaceb4d14f4e16a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/15579266e58d7cdf4ff8e7ad7a4fa30a0bd3a589
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review LI-Qingwu/iio-accel-sca3300-add-compatible-for-scl3300/20220513-000857
git checkout 15579266e58d7cdf4ff8e7ad7a4fa30a0bd3a589
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/iio/accel/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/iio/accel/sca3300.c:288:54: warning: & has lower precedence than ==; == will be evaluated first [-Wparentheses]
if (sca_data->chip->avail_modes_table[i] == reg_val&0x03)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
drivers/iio/accel/sca3300.c:288:54: note: place parentheses around the '==' expression to silence this warning
if (sca_data->chip->avail_modes_table[i] == reg_val&0x03)
^
( )
drivers/iio/accel/sca3300.c:288:54: note: place parentheses around the & expression to evaluate it first
if (sca_data->chip->avail_modes_table[i] == reg_val&0x03)
^
( )
1 warning generated.


vim +288 drivers/iio/accel/sca3300.c

276
277 static int sca3300_get_op_mode(struct sca3300_data *sca_data, int *index)
278 {
279 int reg_val;
280 int ret;
281 int i;
282
283 ret = sca3300_read_reg(sca_data, SCA3300_REG_MODE, &reg_val);
284 if (ret)
285 return ret;
286
287 for (i = 0; i < sca_data->chip->num_avail_modes; i++) {
> 288 if (sca_data->chip->avail_modes_table[i] == reg_val&0x03)
289 break;
290 }
291
292 if (i >= sca_data->chip->num_avail_modes)
293 return -EINVAL;
294
295 *index = i;
296 return 0;
297 }
298

--
0-DAY CI Kernel Test Service
https://01.org/lkp

\
 
 \ /
  Last update: 2022-05-13 03:01    [W:0.092 / U:0.604 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site