Messages in this thread | | | From | Jim Mattson <> | Date | Thu, 12 May 2022 16:23:04 -0700 | Subject | Re: [PATCH 2/3] KVM: x86: Use explicit case-statements for MCx banks in {g,s}et_msr_mce() |
| |
On Thu, May 12, 2022 at 3:27 PM Sean Christopherson <seanjc@google.com> wrote: > > Use an explicit case statement to grab the full range of MCx bank MSRs > in {g,s}et_msr_mce(), and manually check only the "end" (the number of > banks configured by userspace may be less than the max). The "default" > trick works, but is a bit odd now, and will be quite odd if/when support > for accessing MCx_CTL2 MSRs is added, which has near identical logic. > > Hoist "offset" to function scope so as to avoid curly braces for the case > statement, and because MCx_CTL2 support will need the same variables. > > Opportunstically clean up the comment about allowing bit 10 to be cleared > from bank 4. > > No functional change intended. > > Cc: Jue Wang <juew@google.com> > Signed-off-by: Sean Christopherson <seanjc@google.com> > --- Reviewed-by: Jim Mattson <jmattson@google.com>
| |