Messages in this thread | | | From | Stephen Boyd <> | Date | Thu, 12 May 2022 11:42:10 -0700 | Subject | Re: [PATCH 1/3] dt-bindings: arm: qcom: Add sc7180 Chromebook board bindings |
| |
Quoting Douglas Anderson (2022-05-12 09:04:45) > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index 5c06d1bfc046..399be67eb5d2 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -214,11 +214,191 @@ properties: > - qcom,ipq8074-hk10-c2 > - const: qcom,ipq8074 >
Side note: The top of this file describes a scheme that is basically not used by any compatibles in this file. I came up with that scheme many years ago so that we could upstream DTS files but still be able to generate the magic numbers that the bootloader picked DTBs by. I hope nobody assumes that description applies to "google," prefixed compatibles.
Can the description can be amended to indicate the "google," scheme with rev and sku details? Or a bindings/arm/chrome.yaml file could be made and all google prefix chromeos board compatibles could be put in there regardless of SoC used.
> + # Qualcomm Technologies, Inc. SC7180 IDP > - items: > - enum: > - qcom,sc7180-idp > - const: qcom,sc7180 > > + # Google CoachZ (rev1 - 2)
Can we follow the design of rockchip.yaml and also include the marketing name (if published)? That helps folks match things up quicker.
| |