lkml.org 
[lkml]   [2022]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 2/3] kunit: tool: make parser stop overwriting status of suites w/ no_tests
    On Tue, Apr 26, 2022 at 1:33 PM Daniel Latypov <dlatypov@google.com> wrote:
    >
    > Consider this invocation
    > $ ./tools/testing/kunit/kunit.py parse <<EOF
    > TAP version 14
    > 1..2
    > ok 1 - suite
    > # Subtest: no_tests_suite
    > # catastrophic error!
    > not ok 1 - no_tests_suite
    > EOF
    >
    > It will have a 0 exit code even though there's a "not ok".
    >
    > Consider this one:
    > $ ./tools/testing/kunit/kunit.py parse <<EOF
    > TAP version 14
    > 1..2
    > ok 1 - suite
    > not ok 1 - no_tests_suite
    > EOF
    >
    > It will a non-zero exit code.
    >
    > Why?
    > We have this line in the kunit_parser.py
    > > parent_test = parse_test_header(lines, test)
    > where we have special handling when we see "# Subtest" and we ignore the
    > explicit reported "not ok 1" status!
    >
    > Also, NO_TESTS at a suite-level only results in a non-zero status code
    > where then there's only one suite atm.
    >
    > This change is the minimal one to make sure we don't overwrite it.
    >
    > Signed-off-by: Daniel Latypov <dlatypov@google.com>

    Reviewed-by: Brendan Higgins <brendanhiggins@google.com>

    \
     
     \ /
      Last update: 2022-05-12 19:54    [W:4.624 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site