lkml.org 
[lkml]   [2022]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4 2/3] dt-bindings: nvmem: mediatek: document deprecated efuse property
From
On 10/05/2022 15:26, Allen-KH Cheng wrote:
> From: Allen-kh Cheng <allen-kh.cheng@mediatek.corp-partner.google.com>
>
> We mark mediatek,mt8173-efuse and mediatek,efuse as deprecated to
> prevent them from being the single compatible in the future.
>
> The mediatek,efuse compatible should be used as generic fallback for
> all MediaTek chipsets.
>
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> ---
> .../devicetree/bindings/nvmem/mediatek,efuse.yaml | 15 +++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml
> index 529f5888d93f..04ecf5980b2e 100644
> --- a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml
> @@ -16,16 +16,18 @@ allOf:
> properties:
> compatible:
> oneOf:
> - - enum:
> - - mediatek,mt8173-efuse
> - - mediatek,efuse
> + - const: mediatek,mt8173-efuse # Don't use this in new dts files
> + deprecated: true
> + - const: mediatek,efuse
> + deprecated: true
> description:
> - Only mt8173 SoC-specific compatible with generic fallback should be
> - used
> + Please use mediatek,efuse as generic fallback to enable the MediaTek
> + eFuse support.

Now I see the change, it's a bit surprising to have it in separate
patch, but ok. In such case, in your first patch don't add this
description. There is no point to add a description which immediately
you change in next patch.


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-05-11 17:21    [W:0.060 / U:0.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site