lkml.org 
[lkml]   [2022]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/7] irqchip/stm32-exti: manage IMR at each mask/unmask for direct event
On Tue, 10 May 2022 17:41:18 +0100,
Antonio Borneo <antonio.borneo@foss.st.com> wrote:
>
> From: Loic Pallardy <loic.pallardy@foss.st.com>
>
> Enable EXTI line through IMR also on direct event.

Notice how none of the words above say *anything* about mask/unmask?
What happens? What breaks? Is it a fix? If so, what does it fix?

M.

>
> Signed-off-by: Loic Pallardy <loic.pallardy@foss.st.com>
> Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
> ---
> drivers/irqchip/irq-stm32-exti.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c
> index 10c9c742c216..1145f064faa8 100644
> --- a/drivers/irqchip/irq-stm32-exti.c
> +++ b/drivers/irqchip/irq-stm32-exti.c
> @@ -691,8 +691,8 @@ static struct irq_chip stm32_exti_h_chip_direct = {
> .name = "stm32-exti-h-direct",
> .irq_eoi = irq_chip_eoi_parent,
> .irq_ack = irq_chip_ack_parent,
> - .irq_mask = irq_chip_mask_parent,
> - .irq_unmask = irq_chip_unmask_parent,
> + .irq_mask = stm32_exti_h_mask,
> + .irq_unmask = stm32_exti_h_unmask,
> .irq_retrigger = irq_chip_retrigger_hierarchy,
> .irq_set_type = irq_chip_set_type_parent,
> .irq_set_wake = stm32_exti_h_set_wake,
> --
> 2.36.0
>
>

--
Without deviation from the norm, progress is not possible.

\
 
 \ /
  Last update: 2022-05-11 10:06    [W:0.143 / U:0.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site