Messages in this thread | | | From | Nick Desaulniers <> | Date | Wed, 11 May 2022 15:28:07 -0700 | Subject | Re: [PATCH v5 01/12] modpost: split the section mismatch checks into section-check.c |
| |
On Wed, May 11, 2022 at 9:49 AM Masahiro Yamada <masahiroy@kernel.org> wrote: > > modpost.c is too big, and the half of the code is for section checks. > Split it. > > Also, move some related typedefs and macros from modpost.h to > section-check.c > > Copy Sam's Copyright there. Commit b39927cf4cc5 ("kbuild: check for > section mismatch during modpost stage") is the initial work for the > section checks. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Sorry again for my "brain fart" in reviewing the global var in v4. :( I think my blood sugar was getting low or something...
> --- > > Changes in v5: > - Fix the build error (spotted by Nathan) > - Do not do codying style changes (Suggested by Nick)
I'm surprised the style changes didn't show up in v5 as a later patch in the series. I wasn't against them in general, just thought it would be easier to review if they were distinct commits. -- Thanks, ~Nick Desaulniers
| |