Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 11 May 2022 23:34:06 +0200 | Subject | Re: [PATCH v2] drivers: gpio: zevio: drop of_gpio.h header |
| |
On Wed, May 11, 2022 at 11:00 PM Moses Christopher Bollavarapu <mosescb.dev@gmail.com> wrote: > > Remove of_gpio.h header file, replace of_* functions and structs > with appropriate alternatives.
...
> V1 -> V2: Move gpio_chip member to top of the struct > Use dev_error_probe instead of dev_err > Minor style fixes
Almost, see below.
...
> + controller->regs = devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(controller->regs)) > + dev_err_probe(&pdev->dev, PTR_ERR(controller->regs), > + "failed to ioremap memory resource\n");
You forgot 'return'.
-- With Best Regards, Andy Shevchenko
| |