Messages in this thread | | | Date | Wed, 11 May 2022 08:51:16 +0200 | Subject | Re: [PATCH v4 1/1] soc: fujitsu: Add A64FX diagnostic interrupt driver | From | Jiri Slaby <> |
| |
On 11. 05. 22, 8:21, Hitomi Hasegawa wrote: > --- /dev/null > +++ b/drivers/soc/fujitsu/a64fx-diag.c > @@ -0,0 +1,155 @@ ... > +#define BMC_DIAG_INTERRUPT_STATUS_OFFSET (0x0044) > +#define BMC_DIAG_INTERRUPT_ENABLE_OFFSET (0x0040)
And I noticed here, I would: * remove unneeded parentheses * drop the "_OFFSET" suffix * just write 8bit values (0x40, 0x44), given they fit * order them numerically, 0x40 goes first
thanks, -- js suse labs
| |