Messages in this thread | | | Date | Wed, 11 May 2022 11:03:04 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH v2 2/4] watchdog: simatic-ipc-wdt: convert to use P2SB accessor |
| |
On 5/11/22 08:39, Henning Schild wrote: > Since we have a common P2SB accessor in tree we may use it instead of > open coded variants. > > Replace custom code by p2sb_bar() call. > > Signed-off-by: Henning Schild <henning.schild@siemens.com> > --- > drivers/watchdog/Kconfig | 1 + > drivers/watchdog/simatic-ipc-wdt.c | 15 ++++++++------- > 2 files changed, 9 insertions(+), 7 deletions(-) > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index c4e82a8d863f..643a8f5a97b1 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -1628,6 +1628,7 @@ config SIEMENS_SIMATIC_IPC_WDT > tristate "Siemens Simatic IPC Watchdog" > depends on SIEMENS_SIMATIC_IPC > select WATCHDOG_CORE > + select P2SB if X86
Why "if X86" ? SIEMENS_SIMATIC_IPC already depends on it.
Also, I just noticed that P2SB is neither in mainline nor in linux-next, meaning this code won't even compile right now. That should be mentioned in the introduction e-mail (the use of "introduced" suggests that it is already there; you could just use "will be introduced" instead).
Thanks, Guenter
| |