lkml.org 
[lkml]   [2022]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 15/70] net: stmmac: disable Split Header (SPH) for Intel platforms
    Date
    From: Tan Tee Min <tee.min.tan@linux.intel.com>

    commit 47f753c1108e287edb3e27fad8a7511a9d55578e upstream.

    Based on DesignWare Ethernet QoS datasheet, we are seeing the limitation
    of Split Header (SPH) feature is not supported for Ipv4 fragmented packet.
    This SPH limitation will cause ping failure when the packets size exceed
    the MTU size. For example, the issue happens once the basic ping packet
    size is larger than the configured MTU size and the data is lost inside
    the fragmented packet, replaced by zeros/corrupted values, and leads to
    ping fail.

    So, disable the Split Header for Intel platforms.

    v2: Add fixes tag in commit message.

    Fixes: 67afd6d1cfdf("net: stmmac: Add Split Header support and enable it in XGMAC cores")
    Cc: <stable@vger.kernel.org> # 5.10.x
    Suggested-by: Ong, Boon Leong <boon.leong.ong@intel.com>
    Signed-off-by: Mohammad Athari Bin Ismail <mohammad.athari.ismail@intel.com>
    Signed-off-by: Wong Vee Khee <vee.khee.wong@linux.intel.com>
    Signed-off-by: Tan Tee Min <tee.min.tan@linux.intel.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 1 +
    drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
    include/linux/stmmac.h | 1 +
    3 files changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c
    +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c
    @@ -243,6 +243,7 @@ static int intel_mgbe_common_data(struct
    plat->has_gmac4 = 1;
    plat->force_sf_dma_mode = 0;
    plat->tso_en = 1;
    + plat->sph_disable = 1;

    plat->rx_sched_algorithm = MTL_RX_ALGORITHM_SP;

    --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
    +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
    @@ -5046,7 +5046,7 @@ int stmmac_dvr_probe(struct device *devi
    dev_info(priv->device, "TSO feature enabled\n");
    }

    - if (priv->dma_cap.sphen) {
    + if (priv->dma_cap.sphen && !priv->plat->sph_disable) {
    ndev->hw_features |= NETIF_F_GRO;
    priv->sph = true;
    dev_info(priv->device, "SPH feature enabled\n");
    --- a/include/linux/stmmac.h
    +++ b/include/linux/stmmac.h
    @@ -203,5 +203,6 @@ struct plat_stmmacenet_data {
    bool vlan_fail_q_en;
    u8 vlan_fail_q;
    unsigned int eee_usecs_rate;
    + bool sph_disable;
    };
    #endif

    \
     
     \ /
      Last update: 2022-05-10 15:50    [W:4.163 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site