Messages in this thread | | | Subject | Re: [PATCH net v2] net: macsec: retrieve the XPN attributes before offloading | From | Paolo Abeni <> | Date | Tue, 10 May 2022 09:09:53 +0200 |
| |
Hello,
On Fri, 2022-05-06 at 12:55 +0200, Carlos Fernandez wrote: > When MACsec offloading is used with XPN, before mdo_add_rxsa > and mdo_add_txsa functions are called, the key salt is not > copied to the macsec context struct. Offloaded phys will need > this data when performing offloading. > > Fix by copying salt and id to context struct before calling the > offloading functions. > > Fixes: 48ef50fa866a ("macsec: Netlink support of XPN cipher suites") > > Signed-off-by: Carlos Fernandez <carlos.fernandez@technica-engineering.de>
I'm sorry for nit-picking, but you must avoid empty lines between the the 'Fixes' and the 'Signed-off-by' tags (or any other tag).
Additionnaly you should include a summary of the changes WRT the previous patch version, see e.g. commit cec16052d5a7.
The patch contents looks good, but it's better if you address the above, thanks!
Paolo
| |