lkml.org 
[lkml]   [2022]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 25/88] phy: samsung: Fix missing of_node_put() in exynos_sata_phy_probe
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 388ec8f079f2f20d5cd183c3bc6f33cbc3ffd3ef ]

    The device_node pointer is returned by of_parse_phandle() with refcount
    incremented. We should use of_node_put() on it when done.

    Fixes: bcff4cba41bc ("PHY: Exynos: Add Exynos5250 SATA PHY driver")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
    Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
    Link: https://lore.kernel.org/r/20220407091857.230386-1-krzysztof.kozlowski@linaro.org
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/phy/samsung/phy-exynos5250-sata.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/phy/samsung/phy-exynos5250-sata.c b/drivers/phy/samsung/phy-exynos5250-sata.c
    index 60e13afcd9b8..7960c69d09a6 100644
    --- a/drivers/phy/samsung/phy-exynos5250-sata.c
    +++ b/drivers/phy/samsung/phy-exynos5250-sata.c
    @@ -193,6 +193,7 @@ static int exynos_sata_phy_probe(struct platform_device *pdev)
    return -EINVAL;

    sata_phy->client = of_find_i2c_device_by_node(node);
    + of_node_put(node);
    if (!sata_phy->client)
    return -EPROBE_DEFER;

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-05-10 15:40    [W:2.188 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site