lkml.org 
[lkml]   [2022]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 77/88] selftests: mirror_gre_bridge_1q: Avoid changing PVID while interface is operational
    Date
    From: Ido Schimmel <idosch@nvidia.com>

    commit 3122257c02afd9f199a8fc84ae981e1fc4958532 upstream.

    In emulated environments, the bridge ports enslaved to br1 get a carrier
    before changing br1's PVID. This means that by the time the PVID is
    changed, br1 is already operational and configured with an IPv6
    link-local address.

    When the test is run with netdevs registered by mlxsw, changing the PVID
    is vetoed, as changing the VID associated with an existing L3 interface
    is forbidden. This restriction is similar to the 8021q driver's
    restriction of changing the VID of an existing interface.

    Fix this by taking br1 down and bringing it back up when it is fully
    configured.

    With this fix, the test reliably passes on top of both the SW and HW
    data paths (emulated or not).

    Fixes: 239e754af854 ("selftests: forwarding: Test mirror-to-gretap w/ UL 802.1q")
    Signed-off-by: Ido Schimmel <idosch@nvidia.com>
    Reviewed-by: Petr Machata <petrm@nvidia.com>
    Link: https://lore.kernel.org/r/20220502084507.364774-1-idosch@nvidia.com
    Signed-off-by: Paolo Abeni <pabeni@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    tools/testing/selftests/net/forwarding/mirror_gre_bridge_1q.sh | 3 +++
    1 file changed, 3 insertions(+)

    --- a/tools/testing/selftests/net/forwarding/mirror_gre_bridge_1q.sh
    +++ b/tools/testing/selftests/net/forwarding/mirror_gre_bridge_1q.sh
    @@ -61,9 +61,12 @@ setup_prepare()

    vrf_prepare
    mirror_gre_topo_create
    + # Avoid changing br1's PVID while it is operational as a L3 interface.
    + ip link set dev br1 down

    ip link set dev $swp3 master br1
    bridge vlan add dev br1 vid 555 pvid untagged self
    + ip link set dev br1 up
    ip address add dev br1 192.0.2.129/28
    ip address add dev br1 2001:db8:2::1/64


    \
     
     \ /
      Last update: 2022-05-10 15:39    [W:4.020 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site