lkml.org 
[lkml]   [2022]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 39/88] bus: sunxi-rsb: Fix the return value of sunxi_rsb_device_create()
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    [ Upstream commit fff8c10368e64e7f8960f149375c12ca5f3b30af ]

    This code is really spurious.
    It always returns an ERR_PTR, even when err is known to be 0 and calls
    put_device() after a successful device_register() call.

    It is likely that the return statement in the normal path is missing.
    Add 'return rdev;' to fix it.

    Fixes: d787dcdb9c8f ("bus: sunxi-rsb: Add driver for Allwinner Reduced Serial Bus")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Reviewed-by: Samuel Holland <samuel@sholland.org>
    Tested-by: Samuel Holland <samuel@sholland.org>
    Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
    Link: https://lore.kernel.org/r/ef2b9576350bba4c8e05e669e9535e9e2a415763.1650551719.git.christophe.jaillet@wanadoo.fr
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/bus/sunxi-rsb.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/bus/sunxi-rsb.c b/drivers/bus/sunxi-rsb.c
    index 2ca2cc56bcef..b85d013a9185 100644
    --- a/drivers/bus/sunxi-rsb.c
    +++ b/drivers/bus/sunxi-rsb.c
    @@ -224,6 +224,8 @@ static struct sunxi_rsb_device *sunxi_rsb_device_create(struct sunxi_rsb *rsb,

    dev_dbg(&rdev->dev, "device %s registered\n", dev_name(&rdev->dev));

    + return rdev;
    +
    err_device_add:
    put_device(&rdev->dev);

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-05-10 15:36    [W:3.044 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site