lkml.org 
[lkml]   [2022]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 40/88] clk: sunxi: sun9i-mmc: check return value after calling platform_get_resource()
    Date
    From: Yang Yingliang <yangyingliang@huawei.com>

    [ Upstream commit f58ca215cda1975f77b2b762903684a3c101bec9 ]

    It will cause null-ptr-deref if platform_get_resource() returns NULL,
    we need check the return value.

    Fixes: 7a6fca879f59 ("clk: sunxi: Add driver for A80 MMC config clocks/resets")
    Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
    Reviewed-by: Samuel Holland <samuel@sholland.org>
    Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
    Link: https://lore.kernel.org/r/20220421134308.2885094-1-yangyingliang@huawei.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/clk/sunxi/clk-sun9i-mmc.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/clk/sunxi/clk-sun9i-mmc.c b/drivers/clk/sunxi/clk-sun9i-mmc.c
    index f00d8758ba24..a706ae9a010a 100644
    --- a/drivers/clk/sunxi/clk-sun9i-mmc.c
    +++ b/drivers/clk/sunxi/clk-sun9i-mmc.c
    @@ -117,6 +117,8 @@ static int sun9i_a80_mmc_config_clk_probe(struct platform_device *pdev)
    spin_lock_init(&data->lock);

    r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
    + if (!r)
    + return -EINVAL;
    /* one clock/reset pair per word */
    count = DIV_ROUND_UP((resource_size(r)), SUN9I_MMC_WIDTH);
    data->membase = devm_ioremap_resource(&pdev->dev, r);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-05-10 15:36    [W:4.270 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site