lkml.org 
[lkml]   [2022]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 14/88] usb: gadget: configfs: clear deactivation flag in configfs_composite_unbind()
    Date
    From: Vijayavardhan Vennapusa <vvreddy@codeaurora.org>

    commit bf95c4d4630c7a2c16e7b424fdea5177d9ce0864 upstream.

    If any function like UVC is deactivating gadget as part of composition
    switch which results in not calling pullup enablement, it is not getting
    enabled after switch to new composition due to this deactivation flag
    not cleared. This results in USB enumeration not happening after switch
    to new USB composition. Hence clear deactivation flag inside gadget
    structure in configfs_composite_unbind() before switch to new USB
    composition.

    Signed-off-by: Vijayavardhan Vennapusa <vvreddy@codeaurora.org>
    Signed-off-by: Dan Vacura <w36195@motorola.com>
    Cc: stable <stable@kernel.org>
    Link: https://lore.kernel.org/r/20220413211038.72797-1-w36195@motorola.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/usb/gadget/configfs.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/usb/gadget/configfs.c
    +++ b/drivers/usb/gadget/configfs.c
    @@ -1412,6 +1412,8 @@ static void configfs_composite_unbind(st
    usb_ep_autoconfig_reset(cdev->gadget);
    spin_lock_irqsave(&gi->spinlock, flags);
    cdev->gadget = NULL;
    + cdev->deactivations = 0;
    + gadget->deactivated = false;
    set_gadget_data(gadget, NULL);
    spin_unlock_irqrestore(&gi->spinlock, flags);
    }

    \
     
     \ /
      Last update: 2022-05-10 15:30    [W:4.127 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site