lkml.org 
[lkml]   [2022]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 24/66] ARM: OMAP2+: Fix refcount leak in omap_gic_of_init
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 0f83e6b4161617014017a694888dd8743f46f071 ]

    The of_find_compatible_node() function returns a node pointer with
    refcount incremented, We should use of_node_put() on it when done
    Add the missing of_node_put() to release the refcount.

    Fixes: fd1c07861491 ("ARM: OMAP4: Fix the init code to have OMAP4460 errata available in DT build")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Message-Id: <20220309104302.18398-1-linmq006@gmail.com>
    Signed-off-by: Tony Lindgren <tony@atomide.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/arm/mach-omap2/omap4-common.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/arch/arm/mach-omap2/omap4-common.c b/arch/arm/mach-omap2/omap4-common.c
    index e5dcbda20129..7fff67ea7bcd 100644
    --- a/arch/arm/mach-omap2/omap4-common.c
    +++ b/arch/arm/mach-omap2/omap4-common.c
    @@ -342,10 +342,12 @@ void __init omap_gic_of_init(void)

    np = of_find_compatible_node(NULL, NULL, "arm,cortex-a9-gic");
    gic_dist_base_addr = of_iomap(np, 0);
    + of_node_put(np);
    WARN_ON(!gic_dist_base_addr);

    np = of_find_compatible_node(NULL, NULL, "arm,cortex-a9-twd-timer");
    twd_base = of_iomap(np, 0);
    + of_node_put(np);
    WARN_ON(!twd_base);

    skip_errata_init:
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-05-10 15:15    [W:4.060 / U:0.344 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site