Messages in this thread | | | Subject | Re: [PATCH 3/5] genirq: Provide an IRQ affinity mask in non-SMP configs | From | Samuel Holland <> | Date | Mon, 9 May 2022 23:20:05 -0500 |
| |
On 5/9/22 2:52 AM, kernel test robot wrote: > Hi Samuel, > > I love your patch! Yet something to improve: > > [auto build test ERROR on tip/irq/core] > [also build test ERROR on soc/for-next linus/master v5.18-rc6 next-20220506] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/intel-lab-lkp/linux/commits/Samuel-Holland/genirq-irqchip-RISC-V-PLIC-cleanup-and-optimization/20220509-115510 > base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git ce4818957fdc5bca57fc2c92b0dfe109d26bcc47 > config: mips-randconfig-r024-20220509 (https://download.01.org/0day-ci/archive/20220509/202205091545.QhhCDxVm-lkp@intel.com/config) > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project a385645b470e2d3a1534aae618ea56b31177639f) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install mips cross compiling tool for clang build > # apt-get install binutils-mips-linux-gnu > # https://github.com/intel-lab-lkp/linux/commit/4bca5b436c97eb2ee232dd23f262ebad05fa183c > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Samuel-Holland/genirq-irqchip-RISC-V-PLIC-cleanup-and-optimization/20220509-115510 > git checkout 4bca5b436c97eb2ee232dd23f262ebad05fa183c > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > > All errors (new ones prefixed by >>): > >>> kernel/irq/ipi.c:94:30: error: no member named 'affinity' in 'struct irq_common_data' > cpumask_copy(data->common->affinity, dest); > ~~~~~~~~~~~~ ^ > 1 error generated.
I think the fix here is to make GENERIC_IRQ_IPI also depend on SMP. I will add a patch doing this for v2.
Regards, Samuel
| |