Messages in this thread | | | Date | Tue, 10 May 2022 13:56:54 +0200 | Subject | Re: [PATCH] tpm: increase timeout for kselftests | From | Paul Menzel <> |
| |
Dear Johannes,
Thank you for your patch.
Am 10.05.22 um 13:16 schrieb Johannes Holland:
Should you resend, maybe be more specific in the commit message summary. Maybe:
Double timeout for kselftests to 10 min
> Due to CreatePrimary commands which need to create RSA keys of > increasing size, the timeout value need to be raised, as well.
need*s*?
> Default is 300s.
Mention 600 ms somewhere?
> Signed-off-by: Johannes Holland <johannes.holland@infineon.com> > --- > A timeout of anything below 600s still lead to occasional timeouts for > me. Therefore, I propose 600s as a new value.
I’d say, this should go into the commit message. Maybe even say, what devices you are testing with.
Kind regards,
Paul
> tools/testing/selftests/tpm2/settings | 2 ++ > 1 file changed, 2 insertions(+) > create mode 100644 tools/testing/selftests/tpm2/settings > > diff --git a/tools/testing/selftests/tpm2/settings b/tools/testing/selftests/tpm2/settings > new file mode 100644 > index 000000000000..919bc3803f03 > --- /dev/null > +++ b/tools/testing/selftests/tpm2/settings > @@ -0,0 +1,2 @@ > +timeout=600 > +
| |