Messages in this thread | | | Date | Tue, 10 May 2022 10:49:55 +0100 | Subject | Re: [PATCH 2/2] slimbus: qcom: Remove unnecessary print function dev_err() | From | Srinivas Kandagatla <> |
| |
On 09/05/2022 14:42, Greg KH wrote: > On Fri, Apr 29, 2022 at 05:50:51PM +0100, Srinivas Kandagatla wrote: >> From: Yang Li <yang.lee@linux.alibaba.com> >> >> The print function dev_err() is redundant because >> platform_get_irq_byname() already prints an error. >> >> Eliminate the follow coccicheck warning: >> ./drivers/slimbus/qcom-ctrl.c:514:2-9: line 514 is redundant because >> platform_get_irq() already prints an error >> >> Reported-by: Abaci Robot <abaci@linux.alibaba.com> >> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >> --- >> drivers/slimbus/qcom-ctrl.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c >> index ec58091fc948..c0c4f895d76e 100644 >> --- a/drivers/slimbus/qcom-ctrl.c >> +++ b/drivers/slimbus/qcom-ctrl.c >> @@ -510,10 +510,8 @@ static int qcom_slim_probe(struct platform_device *pdev) >> } >> >> ctrl->irq = platform_get_irq(pdev, 0); >> - if (ctrl->irq < 0) { >> - dev_err(&pdev->dev, "no slimbus IRQ\n"); >> + if (ctrl->irq < 0) >> return ctrl->irq; >> - } >> >> sctrl = &ctrl->ctrl; >> sctrl->dev = &pdev->dev; >> -- >> 2.21.0 >> > > Does not apply to my tree :( Sorry my bad.. I see there was a depended fix[1] that needs to go in first. I was hoping that that will be applied first.. Let me resend them together in v2.
[1] https://lkml.org/lkml/2022/4/29/1093
Thanks, srini > >
| |