Messages in this thread | | | Date | Wed, 11 May 2022 11:23:04 +0800 | Subject | Re: [PATCH v2 net] net: phy: mscc: Add error check when __phy_read() failed | From | Jiabing Wan <> |
| |
On 2022/5/10 23:33, Antoine Tenart wrote: > Quoting Andrew Lunn (2022-05-10 17:08:07) >> But i doubt this impacts real users. MDIO tends to either work or not >> work at all. And not working is pretty noticeable, and nobody has >> reported issues. > Right. On top of that there are other calls to __phy_read in this driver > not checking the returned value. Plus all __phy_write calls. If that was > found by code inspection I would suggest to improve the whole driver and > not this function alone. OK, I'll try to improve the whole driver and send a patch set for this.
Thanks, Wan Jiabing
| |