Messages in this thread | | | Date | Tue, 10 May 2022 17:23:49 +0800 | Subject | Re: [PATCH v2] cpufreq: mediatek: Fix potential deadlock problem in mtk_cpufreq_set_target | From | Jiabing Wan <> |
| |
On 2022/5/10 17:12, Viresh Kumar wrote: > On 10-05-22, 17:05, Wan Jiabing wrote: >> Fix following coccichek error: >> ./drivers/cpufreq/mediatek-cpufreq.c:199:2-8: preceding lock on line >> ./drivers/cpufreq/mediatek-cpufreq.c:208:2-8: preceding lock on line >> >> mutex_lock is acquired but not released before return. >> Use 'goto out' to help releasing the mutex_lock. >> >> Fixes: c210063b40ac ("cpufreq: mediatek: Add opp notification support") >> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com> > You should have added the review tag you received. > > Applied. Thanks.
Oh, yes. I would add the "Reviewed-by:" tag only if someone sends this tag to me.
Like: [0] https://lore.kernel.org/all/YnkvM5iuSuAOqBg+@lunn.ch/ [1] https://lore.kernel.org/all/20220510015521.2542096-1-wanjiabing@vivo.com/
If not explicitly stated, I am afraid to add some wrong "Reviewed-by:" tags which might bother maintainers.
Thanks a lot for your priceless advice!
Wan Jiabing
| |