Messages in this thread | | | From | Andrey Konovalov <> | Date | Tue, 10 May 2022 19:18:21 +0200 | Subject | Re: [PATCH 1/3] kasan: update documentation |
| |
On Tue, May 10, 2022 at 2:06 PM Marco Elver <elver@google.com> wrote: > > > -For tag-based KASAN modes (include the hardware one), to disable access > > +For tag-based KASAN modes (include the Hardware one), to disable access > > The changes related to capitalization appear weird here. At least in > this case, it starts with "tag-based" (lower case) and then in braces > ".. the Hardware one". This does not look like correct English. > > The "hardware" here is not part of a name, so no need for > capitalization. And "tag-based" can also stay lower case, since it is > not part of a name either, but an adjective to "KASAN". > > Or you rewrite the sentence.
Yeah, I agree that this looks weird. I'll just drop the part in parentheses in v2. Thanks!
| |