lkml.org 
[lkml]   [2022]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3] ath10k: improve BDF search fallback strategy
Date
Kalle Valo <kvalo@kernel.org> writes:

>> static int ath10k_core_fetch_board_data_api_n(struct ath10k *ar,
>> const char *boardname,
>> - const char *fallback_boardname1,
>> - const char *fallback_boardname2,
>> const char *filename)
>> {
>> - size_t len, magic_len;
>> + size_t len, magic_len, board_len;
>> const u8 *data;
>> int ret;
>> + char temp_boardname[100];
>> +
>> + board_len = 100 * sizeof(temp_boardname[0]);
>
> Why not:
>
> board_len = sizeof(temp_board-name);
>
> That way number 100 is used only once.

BTW I'm not sure if it makes sense to CC David, Eric, Jakub and Paolo.
I'm sure they get a lot of email already. And I would also drop netdev.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

\
 
 \ /
  Last update: 2022-05-10 17:55    [W:0.067 / U:1.804 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site