Messages in this thread | | | From | Antoine Tenart <> | Subject | Re: [PATCH v2 net] net: phy: mscc: Add error check when __phy_read() failed | Date | Tue, 10 May 2022 17:33:56 +0200 |
| |
Quoting Andrew Lunn (2022-05-10 17:08:07) > > But i doubt this impacts real users. MDIO tends to either work or not > work at all. And not working is pretty noticeable, and nobody has > reported issues.
Right. On top of that there are other calls to __phy_read in this driver not checking the returned value. Plus all __phy_write calls. If that was found by code inspection I would suggest to improve the whole driver and not this function alone.
Thanks, Antoine
| |