Messages in this thread | | | From | Arnd Bergmann <> | Date | Tue, 10 May 2022 09:59:29 +0200 | Subject | Re: [PATCH] arm64: dts: mt8173: add aliases for mt8173 mmc device nodes |
| |
On Tue, May 10, 2022 at 9:36 AM Chen-Yu Tsai <wenst@chromium.org> wrote: > On Tue, May 10, 2022 at 1:21 PM Eizan Miyamoto <eizan@chromium.org> wrote: > > > > Doing this makes them get enumerated in a deterministic order so that > > the assigned name in /dev that the mmc devices get assigned is > > consistent across reboots. > > Arnd, one of the soc maintainers asked folks not to do this: > > https://lore.kernel.org/all/CAK8P3a3_uO23Y0tyfdh26tmCVcyp6XM+ur0WUd4khGUoBb32Hw@mail.gmail.com/ > > and subsequently all mmc aliases for Rockchip were moved to the board level.
Right, please move the aliases into the per-board dts files, and make sure to only list the ones that are actually connected on a given machine.
> > See ead9f7d7ea9 ("arm64: dts: qcom: sc7180: Assign numbers to eMMC and > > SD") for similar work. > > I don't know why it didn't happen for Qualcomm though.
It takes a while to get things consistent, need to have another look there.
Arnd
| |