lkml.org 
[lkml]   [2022]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 065/140] net/mlx5e: Fix wrong source vport matching on tunnel rule
    Date
    From: Ariel Levkovich <lariel@nvidia.com>

    commit cb0d54cbf94866b48a73e10a73a55655f808cc7c upstream.

    When OVS internal port is the vtep device, the first decap
    rule is matching on the internal port's vport metadata value
    and then changes the metadata to be the uplink's value.

    Therefore, following rules on the tunnel, in chain > 0, should
    avoid matching on internal port metadata and use the uplink
    vport metadata instead.

    Select the uplink's metadata value for the source vport match
    in case the rule is in chain greater than zero, even if the tunnel
    route device is internal port.

    Fixes: 166f431ec6be ("net/mlx5e: Add indirect tc offload of ovs internal port")
    Signed-off-by: Ariel Levkovich <lariel@nvidia.com>
    Reviewed-by: Maor Dickman <maord@nvidia.com>
    Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
    index 3f63df127091..3b151332e2f8 100644
    --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
    +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
    @@ -139,7 +139,7 @@ mlx5_eswitch_set_rule_source_port(struct mlx5_eswitch *esw,
    if (mlx5_esw_indir_table_decap_vport(attr))
    vport = mlx5_esw_indir_table_decap_vport(attr);

    - if (esw_attr->int_port)
    + if (attr && !attr->chain && esw_attr->int_port)
    metadata =
    mlx5e_tc_int_port_get_metadata_for_match(esw_attr->int_port);
    else
    --
    2.36.1


    \
     
     \ /
      Last update: 2022-05-10 16:25    [W:2.715 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site