lkml.org 
[lkml]   [2022]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 062/135] net: dsa: mt7530: add missing of_node_put() in mt7530_setup()
    Date
    From: Yang Yingliang <yangyingliang@huawei.com>

    commit a9e9b091a1c14ecd8bd9d3214a62142a1786fe30 upstream.

    Add of_node_put() if of_get_phy_mode() fails in mt7530_setup()

    Fixes: 0c65b2b90d13 ("net: of_get_phy_mode: Change API to solve int/unit warnings")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
    Link: https://lore.kernel.org/r/20220428095317.538829-1-yangyingliang@huawei.com
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/dsa/mt7530.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/net/dsa/mt7530.c
    +++ b/drivers/net/dsa/mt7530.c
    @@ -2216,6 +2216,7 @@ mt7530_setup(struct dsa_switch *ds)
    ret = of_get_phy_mode(mac_np, &interface);
    if (ret && ret != -ENODEV) {
    of_node_put(mac_np);
    + of_node_put(phy_node);
    return ret;
    }
    id = of_mdio_parse_addr(ds->dev, phy_node);

    \
     
     \ /
      Last update: 2022-05-10 16:22    [W:2.033 / U:0.496 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site