lkml.org 
[lkml]   [2022]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 060/140] ASoC: soc-ops: fix error handling
    Date
    From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

    commit eb5773201b1c5d603424bd21f161c8c2d1075b42 upstream.

    cppcheck throws the following warning:

    sound/soc/soc-ops.c:461:8: style: Variable 'ret' is assigned a value
    that is never used. [unreadVariable]
    ret = err;
    ^

    This seems to be a missing change in the return value.

    Fixes: 7f3d90a351968 ("ASoC: ops: Fix stereo change notifications in snd_soc_put_volsw_sx()")
    Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
    Reviewed-by: Rander Wang <rander.wang@intel.com>
    Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
    Link: https://lore.kernel.org/r/20220421162328.302017-1-pierre-louis.bossart@linux.intel.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    sound/soc/soc-ops.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/sound/soc/soc-ops.c
    +++ b/sound/soc/soc-ops.c
    @@ -461,7 +461,7 @@ int snd_soc_put_volsw_sx(struct snd_kcon
    ret = err;
    }
    }
    - return err;
    + return ret;
    }
    EXPORT_SYMBOL_GPL(snd_soc_put_volsw_sx);


    \
     
     \ /
      Last update: 2022-05-10 16:20    [W:3.108 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site